fix(beforeSave): Skip Sanitizing Database results #7003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7003 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 169 169
Lines 12405 12405
=======================================
Hits 11638 11638
Misses 767 767
Continue to review full report at Codecov.
|
|
Closes #6358 Will open a separate PR to handle nested objects values properly returning in beforeSave |
mtrezza
added a commit
to mtrezza/parse-server
that referenced
this pull request
Dec 4, 2020
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into Internal Server Error when using beforeSave and nested objects.
Uncaught exception: TypeError: Cannot read property 'split' of undefinederror: Uncaught internal server error. Cannot read property 'number' of undefinedWhen using beforeSave there is a validation permission check. If an object exists it returns
{}and does additional checks on an empty object. ValidateOnly. I believe we can ignore those checks as they don’t have anything to do with beforeSave.Let me know if additional tests are needed.